ci: fix permissions and pass GITHUB_TOKEN for review comments#333
Merged
Conversation
Co-Authored-By: Bohdan Ohorodnii <35969035+varex83@users.noreply.github.com>
varex83
approved these changes
Apr 15, 2026
varex83agent
added a commit
that referenced
this pull request
Apr 15, 2026
…#333) Co-Authored-By: Bohdan Ohorodnii <35969035+varex83@users.noreply.github.com>
emlautarom1
pushed a commit
that referenced
this pull request
Apr 15, 2026
Co-authored-by: Bohdan Ohorodnii <35969035+varex83@users.noreply.github.com>
emlautarom1
pushed a commit
that referenced
this pull request
Apr 15, 2026
Co-authored-by: Bohdan Ohorodnii <35969035+varex83@users.noreply.github.com>
varex83
added a commit
that referenced
this pull request
Apr 16, 2026
* feat: add mev cli tests * clippy * Remove type aliases for test cases - Follow the `test validator` approach (enum + impl block) - Simplify error handling for timeouts * Use `JoinSet` * Consistent argument ordering * Remove select with CT - Test is already cancelled by caller appropriately * Reorder parameters * Remove redundant `CancellationToken`s * Pass main CT * Fix clippy lints - Workaround for false positive * fix(cli/mev): address PR review comments for mev test command - Use tokio::time::Instant instead of std::time::Instant in async code - Replace CliError::Other string literals with typed variants TimeoutInterrupted and TestCaseNotSupported - Remove TestResultError from imports; use CliError::TimeoutInterrupted directly - Simplify latest_beacon_block and fetch_proposers_for_epoch to use ? operator, leveraging existing From impls on CliError - Simplify get_block_header error conversions with .map_err(MevError::from) and .map_err(|e| MevError::Cli(e.into())) Co-Authored-By: Bohdan Ohorodnii <35969035+varex83@users.noreply.github.com> * fix(deny): ignore RUSTSEC advisories for transitive deps RUSTSEC-2026-0097: rand 0.8.x unsoundness (transitive dep) RUSTSEC-2026-0098: rustls-webpki URI name constraint bypass (transitive dep) Co-Authored-By: Bohdan Ohorodnii <35969035+varex83@users.noreply.github.com> * fix(cli/mev): remove x-timeout-ms, custom headers, and credentials These features are absent from Charon v1.7.1: - Remove x-timeout-ms CLI flag and x_timeout_ms field from TestMevArgs - Remove X-Timeout-Ms and Date-Milliseconds headers from get_block_header - Remove credential parsing (parse_endpoint_credentials / apply_basic_auth) from mev_ping_test, latest_beacon_block, fetch_proposers_for_epoch, and get_block_header - Replace x_timeout_ms-based thresholds in mev_create_block_test with fixed 500ms/800ms constants matching Go reference thresholds Co-Authored-By: Bohdan Ohorodnii <35969035+varex83@users.noreply.github.com> * ci: use local /review-pr skill for PR reviews (#331) * ci: use local /review-pr skill for PR reviews Replace the external code-review plugin with the repo's own /review-pr skill, and upgrade pull-requests permission to write so the skill can post inline review comments via the GitHub API. Co-Authored-By: Bohdan Ohorodnii <35969035+varex83@users.noreply.github.com> * ci: trigger review via @claude-review comment Co-Authored-By: Bohdan Ohorodnii <35969035+varex83@users.noreply.github.com> * ci: use /claude-review as comment trigger Co-Authored-By: Bohdan Ohorodnii <35969035+varex83@users.noreply.github.com> * ci: remove claude-code reviewer trigger, keep only /claude-review comment Co-Authored-By: Bohdan Ohorodnii <35969035+varex83@users.noreply.github.com> --------- Co-authored-by: Bohdan Ohorodnii <35969035+varex83@users.noreply.github.com> * ci: fix permissions and pass GITHUB_TOKEN for review comments (#333) Co-authored-by: Bohdan Ohorodnii <35969035+varex83@users.noreply.github.com> * chore: fix cargo deny check (#335) * chore: fix cargo deny check Upgrade rustls-webpki 0.103.10 → 0.103.12 (RUSTSEC-2026-0098, RUSTSEC-2026-0099) and multihash 0.19.3 → 0.19.4 (drops yanked core2 0.4.0). * updated rand to 0.9.4 from 0.9.2 * updated other dependencies * revert: ci: fix permissions and pass GITHUB_TOKEN for review comments (#333) (#334) Co-authored-by: Bohdan Ohorodnii <35969035+varex83@users.noreply.github.com> * Revert deny `ignore` * Pass CT as value instead of ref - Remove unnecessary clones * ci: fix permissions and pass GITHUB_TOKEN for review comments (#333) Co-authored-by: Bohdan Ohorodnii <35969035+varex83@users.noreply.github.com> * revert: ci: fix permissions and pass GITHUB_TOKEN for review comments (#333) (#334) Co-authored-by: Bohdan Ohorodnii <35969035+varex83@users.noreply.github.com> * chore: restore workflow file to match main branch Co-Authored-By: Bohdan Ohorodnii <35969035+varex83@users.noreply.github.com> * fix: revert workflow file changes --------- Co-authored-by: Lautaro Emanuel <emlautarom1@gmail.com> Co-authored-by: Bohdan Ohorodnii <273991985+varex83agent@users.noreply.github.com> Co-authored-by: Bohdan Ohorodnii <35969035+varex83@users.noreply.github.com> Co-authored-by: Maciej Skrzypkowski <mskr@gmx.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #331.
issues: read→write— required for posting PR/issue comments via the GitHub APIgithub_token: ${{ secrets.GITHUB_TOKEN }}— passes credentials to theghCLI insideclaude-code-actionso it can authenticate when posting review comments